[regression] current master is umcompilable

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

[regression] current master is umcompilable

Post by uwestoehr »

Today's changes to use overrides breaks the compilation for me completely.

I get now tons of these errors:

Code: Select all

D:\FreeCAD-git\src\Mod\Part\App\BRepOffsetAPI_MakeOffsetFix.h(59,10): error C3668: 'Part::BRepOffsetAPI_MakeOffsetFix::Build': method with override specifier 'override' did not override any base class methods (compiling source file D:\FreeCAD-git\src\Mod\Part\App\BRepOffsetAPI_MakeOffsetFix.cpp)
...
13>D:\FreeCAD-git\src\Mod\Part\App\FaceMaker.h(78,10): error C3668: 'Part::FaceMaker::Build': method with override specifier 'override' did not override any base class methods (compiling source file D:\FreeCAD-git\src\Mod\Part\App\FaceMakerCheese.cpp)
...
13>D:\FreeCAD-git\src\Mod\Part\App\modelRefine.h(201,10): error C3668: 'Part::BRepBuilderAPI_RefineModel::Build': method with override specifier 'override' did not override any base class methods (compiling source file D:\FreeCAD-git\src\Mod\Part\App\FeaturePartBoolean.cpp)
...
@berniev , @wmayer
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: [regression] current master is umcompilable

Post by uwestoehr »

uwestoehr wrote: Tue Aug 09, 2022 1:55 pm Today's changes to use overrides breaks the compilation for me completely.

I get now tons of these errors:

Code: Select all

D:\FreeCAD-git\src\Mod\Part\App\BRepOffsetAPI_MakeOffsetFix.h(59,10): error C3668: 'Part::BRepOffsetAPI_MakeOffsetFix::Build': method with override specifier 'override' did not override any base class methods (compiling source file D:\FreeCAD-git\src\Mod\Part\App\BRepOffsetAPI_MakeOffsetFix.cpp)
...
13>D:\FreeCAD-git\src\Mod\Part\App\FaceMaker.h(78,10): error C3668: 'Part::FaceMaker::Build': method with override specifier 'override' did not override any base class methods (compiling source file D:\FreeCAD-git\src\Mod\Part\App\FaceMakerCheese.cpp)
...
13>D:\FreeCAD-git\src\Mod\Part\App\modelRefine.h(201,10): error C3668: 'Part::BRepBuilderAPI_RefineModel::Build': method with override specifier 'override' did not override any base class methods (compiling source file D:\FreeCAD-git\src\Mod\Part\App\FeaturePartBoolean.cpp)
...
@berniev , @wmayer
EDIT: it seems there are "only" these 3 errors, that are just repeated many times for all compilation targets that rely on Part.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: [regression] current master is umcompilable

Post by uwestoehr »

OK, there were some more, also in Spreadsheet and Gui. I will commit the fixes (partial reversion) later today
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: [regression] current master is umcompilable

Post by Syres »

uwestoehr wrote: Tue Aug 09, 2022 3:09 pm OK, there were some more, also in Spreadsheet and Gui. I will commit the fixes (partial reversion) later today
Have you also seen https://forum.freecadweb.org/viewtopic.php?f=4&t=70951 , I'm just guessing it's related?
wmayer
Founder
Posts: 20243
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: [regression] current master is umcompilable

Post by wmayer »

I was working until now to get trillions of warnings fixed -- but I hadn't any build failure.

When looking at your failures then the compiler claims that BRepBuilderAPI_MakeShape::Build is not a virtual method. So, I had a look at the OCC 7.6 sources and there indeed the method is declared as:

Code: Select all

Standard_EXPORT virtual void Build(const Message_ProgressRange& theRange = Message_ProgressRange());
This is an important point because it means that some of our sub-classes of BRepBuilderAPI_MakeShape won't work correctly any more due to this API change. Luckily the today's PR revealed this problem.

Please don't commit any changes because I will do it...
User avatar
chennes
Veteran
Posts: 3877
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: [regression] current master is umcompilable

Post by chennes »

I am now down to just the following errors: are you still working on these, @wmayer?

Code: Select all

Severity	Code	Description	Project	File	Line	Suppression State
Error	C3668	'Gui::GestureNavigationStyle::IdleState::~IdleState': method with override specifier 'override' did not override any base class methods	FreeCADGui	C:\Users\chennes\Documents\GitHub\FreeCAD\src\Gui\GestureNavigationStyle.cpp	248	
Error	C3668	'Gui::GestureNavigationStyle::AwaitingMoveState::~AwaitingMoveState': method with override specifier 'override' did not override any base class methods	FreeCADGui	C:\Users\chennes\Documents\GitHub\FreeCAD\src\Gui\GestureNavigationStyle.cpp	374	
Error	C3668	'Gui::GestureNavigationStyle::RotateState::~RotateState': method with override specifier 'override' did not override any base class methods	FreeCADGui	C:\Users\chennes\Documents\GitHub\FreeCAD\src\Gui\GestureNavigationStyle.cpp	497	
Error	C3668	'Gui::GestureNavigationStyle::PanState::~PanState': method with override specifier 'override' did not override any base class methods	FreeCADGui	C:\Users\chennes\Documents\GitHub\FreeCAD\src\Gui\GestureNavigationStyle.cpp	542	
Error	C3668	'Gui::GestureNavigationStyle::StickyPanState::~StickyPanState': method with override specifier 'override' did not override any base class methods	FreeCADGui	C:\Users\chennes\Documents\GitHub\FreeCAD\src\Gui\GestureNavigationStyle.cpp	589	
Error	C3668	'Gui::GestureNavigationStyle::TiltState::~TiltState': method with override specifier 'override' did not override any base class methods	FreeCADGui	C:\Users\chennes\Documents\GitHub\FreeCAD\src\Gui\GestureNavigationStyle.cpp	634	
Error	C3668	'Gui::GestureNavigationStyle::GestureState::~GestureState': method with override specifier 'override' did not override any base class methods	FreeCADGui	C:\Users\chennes\Documents\GitHub\FreeCAD\src\Gui\GestureNavigationStyle.cpp	687	
Error	C3668	'Gui::GestureNavigationStyle::AwaitingReleaseState::~AwaitingReleaseState': method with override specifier 'override' did not override any base class methods	FreeCADGui	C:\Users\chennes\Documents\GitHub\FreeCAD\src\Gui\GestureNavigationStyle.cpp	762	
Error	C3668	'Gui::GestureNavigationStyle::InteractState::~InteractState': method with override specifier 'override' did not override any base class methods	FreeCADGui	C:\Users\chennes\Documents\GitHub\FreeCAD\src\Gui\GestureNavigationStyle.cpp	813	
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
wmayer
Founder
Posts: 20243
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: [regression] current master is umcompilable

Post by wmayer »

chennes wrote: Tue Aug 09, 2022 5:59 pm I am now down to just the following errors: are you still working on these
Although I didn't get a problem there I have reverted the changes of this file. Is there anything else that must be fixed?
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: [regression] current master is umcompilable

Post by uwestoehr »

chennes wrote: Tue Aug 09, 2022 5:59 pm I am now down to just the following errors: are you still working on these, @wmayer?
I got the same. Now master compiles fine for me.
FreddyFreddy
Posts: 176
Joined: Wed Mar 09, 2022 3:15 am
Location: Oz

Re: [regression] current master is umcompilable

Post by FreddyFreddy »

uwestoehr wrote: Tue Aug 09, 2022 1:55 pm @berniev , @wmayer
I didn't see this at the time as my forum id is FreddyFreddy. berniev is my GitHub id. I suppose I should start being berniev on the forum!?
wmayer
Founder
Posts: 20243
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: [regression] current master is umcompilable

Post by wmayer »

FreddyFreddy wrote: Sun Aug 14, 2022 7:40 am
uwestoehr wrote: Tue Aug 09, 2022 1:55 pm @berniev , @wmayer
I didn't see this at the time as my forum id is FreddyFreddy. berniev is my GitHub id. I suppose I should start being berniev on the forum!?
It's OK. Many people have different forum and GH accounts and from the context it's usually quite clear who is who.
Post Reply