I updated now from MSVC 2019 to 2022 but I get the exact same linker error.
[fixed] [regression] [TD] not compilable
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: [regression] [TD] not compilable
There is no need that QGVPage directly inherits from ParameterGrp::ObserverType. It can also be moved to a private class that will be declared and implemented in the source file. So, the QGIView no longer sees the extra ParameterGrp::ObserverType.
So, can you try this please?
So, can you try this please?
- wandererfan
- Veteran
- Posts: 6320
- Joined: Tue Nov 06, 2012 5:42 pm
- Contact:
Re: [regression] [TD] not compilable
@wmayer Thank you. This seems to work fine on linux.
@uwestoehr a branch with the patch applied is available here: https://github.com/WandererFan/FreeCAD/tree/wmPatch
@uwestoehr a branch with the patch applied is available here: https://github.com/WandererFan/FreeCAD/tree/wmPatch
-
- Posts: 98
- Joined: Fri Oct 09, 2020 4:56 pm
- Location: Oregon, USA
Re: [regression] [TD] not compilable
I just pulled and successfully built "master" on Windows 11 with MSVC, so it worked for me, also
Re: [fixed] [regression] [TD] not compilable
@wandererfan
While talking about the issues of git commit 9894964eb69e90 there is one further minor thing:
the class QGSPage defines the members m_renderer, drawBkg and balloonCursor that are initialized in the constructor but then used nowhere else. clang raises e.g. the warning warning: private field 'm_renderer' is not used [-Wunused-private-field].
Will the class QGSPage be extended by using the members in some methods or can they be removed?
While talking about the issues of git commit 9894964eb69e90 there is one further minor thing:
the class QGSPage defines the members m_renderer, drawBkg and balloonCursor that are initialized in the constructor but then used nowhere else. clang raises e.g. the warning warning: private field 'm_renderer' is not used [-Wunused-private-field].
Will the class QGSPage be extended by using the members in some methods or can they be removed?
- wandererfan
- Veteran
- Posts: 6320
- Joined: Tue Nov 06, 2012 5:42 pm
- Contact:
Re: [fixed] [regression] [TD] not compilable
QGSPage (QGraphcisScene) is new and took over some scene related tasks that were in QGVPage (QGraphicsView). It is entirely possible some QGVPage code came along for the ride. Eventually, QGSPage will handle things like box selection of edges.
Thanks for catching this. I will check it out.