Missing "Const" attribute in xml

[dpoen]

Hello,

I might be misunderstanding the meaning of the "Const" in xml for the Python generation (for instance MatrixPy.xml).
I do understand it indicate that to object will not be changed. Correct ?
If so, should be more method received this attribute? For instance the inverse() method should be " Const="true", isn't it ?

I could do the fix, but I do need to know if I'm right,

Code: Select all

OS: Debian GNU/Linux 11 (bullseye) (XFCE/xfce)
Word size of FreeCAD: 64-bit
Version: 0.21.Unknown
Build type: Unknown
Python 3.9.2, Qt 5.15.2, Coin 4.0.0, Vtk 7.1.1, OCC 7.5.1
Locale: English/United States (en_US)

[onekk]

Hello,

I might be misunderstanding the meaning of the "Const" in xml for the Python generation (for instance MatrixPy.xml).
I do understand it indicate that to object will not be changed. Correct ?
If so, should be more method received this attribute? For instance the inverse() method should be " Const="true", isn't it ?

Internals of such things are known by few developers, @wmayer er is the most authoritative person" let's see if poking will make something happens.

Hi and sorry for poking but I think this answer is know by very few people here.

Regards

Carlo D.

[wmayer]

I do understand it indicate that to object will not be changed. Correct ?

Yes, that's correct.

If so, should be more method received this attribute? For instance the inverse() method should be " Const="true", isn't it ?

There still might be functions where we forgot to add this attribute. And yes the inverse() method requires it, too.

I will add it. git commit 7de8a14b37

[dpoen]

the methods multiply(), determinant(), isOrthogonal(), submatrix(), analyze() might also get the const attribute, is that correct ?

[openBrain]

the methods multiply(), determinant(), isOrthogonal(), submatrix(), analyze() might also get the const attribute, is that correct ?

I guess you can prepare a PR on GH. @wmayer will likely check it there directly.

[dpoen]

Yes, that work too xD

[dpoen]

@wmayer, I have a question, which tool actually use those xml ? I expect that to be some sort of code generation stuff, but I can't find it ...

[marioalexis]

You will see the changes in the MatrixPy.xml file reflected in the MatrixPy.cpp and MatrixPy.h files in the build directory once you compile the program.
To see more details about the impact of the xml file tags, you can read src/Tools/generateTemplates/templateClassPyExport.py

[dpoen]

Got it, that is what I was looking for, thank

[adrianinsaval]

@wmayer no clue if this is really related: https://forum.freecadweb.org/viewtopic. ... 10#p565791
but could it be that the function for obj.Shape.scaled is also missing this const attribute?