Page 3 of 3

Re: DXFNext

Posted: Tue Jun 28, 2022 9:07 pm
by adrianinsaval
Gift wrote: Tue Jun 28, 2022 7:38 pm That is your postulate. Internally there is no Part.Wire. That is a function, which create edges. Inspect the result of the script.
Wire is a shape type and it is differentiable from stand alone edges. https://github.com/FreeCAD/FreeCAD/blob ... e.cpp#L465
sliptonic wrote: Tue Jun 28, 2022 8:00 pm if the issue is speed, why not strive to make ezdxf faster?
python might be the limiting factor

Re: DXFNext

Posted: Tue Jun 28, 2022 9:24 pm
by sliptonic
adrianinsaval wrote: Tue Jun 28, 2022 9:07 pm python might be the limiting factor
No argument. But it's the limiting factor for everyone. So it still makes sense to address it upstream.

Re: DXFNext

Posted: Wed Jun 29, 2022 10:17 am
by Gift
adrianinsaval wrote: Tue Jun 28, 2022 9:07 pm Wire is a shape type and it is differentiable from stand alone edges. https://github.com/FreeCAD/FreeCAD/blob ... e.cpp#L465
...
Good idea. Wire could make it possible. Thanks.

Re: DXFNext

Posted: Sat Jul 16, 2022 11:49 am
by uwestoehr
Many thanks for your great work! The new DXF was merged today.
Can you please add something to the release notes?: https://wiki.freecadweb.org/Release_notes_1.0

Also please open a new thread in the General help forum with request to test the next weekly build with real-life DXFs. Usually ;) there will be here and there some issues that will be uncovered by intensive tests.

Re: DXFNext

Posted: Thu Sep 22, 2022 1:46 pm
by NewJoker
@Gift What is the status of this functionality ? It was merged with this PR: https://github.com/FreeCAD/FreeCAD/pull/7101
but is it fully merged or does it require some additional PRs ? Can it be added to the release notes already ?

Re: DXFNext

Posted: Sat Oct 22, 2022 6:38 pm
by Gift
NewJoker wrote: Thu Sep 22, 2022 1:46 pm @Gift What is the status of this functionality ? It was merged with this PR: https://github.com/FreeCAD/FreeCAD/pull/7101
but is it fully merged or does it require some additional PRs ? Can it be added to the release notes already ?
Up to this point, it is a pure code cleaning. Duplicate files were removed and restructured. A vision should be formulated for further steps. The interest for the support of a ready python library was/is quite high.
But this would only comply a part of the task. A solution would be to make a part of the work even more abstract. A kind of general interface. However. More PRs are needed for this.

Re: DXFNext

Posted: Sun Oct 23, 2022 8:23 am
by onekk
Hello, IMHO @Gift solution could be the stock way of managing DXF, at least to eliminate the gap between "python importer" and "C++ importer".

And the library solution could be left for "complicated cases" and as an optional solution.

If obviously @Gift is taking care of the code.

I see the advantage of the external library, but even an out of the box importer and exporter for DXF file, that could manage "not too exotic" cases and with some speed gain it is not a bad thing.

But this from a user point of view.

Postponing solutions or like in this case some improvement to a uncertain future were "someone" will take care of rewriting things is not a good path for evolution.

If @Gift is able and want to take care of this thing I see no problem, if someone will integrate a dxf import library in FreeCAD, perfect we will have more choice.

But actually if there will be no distinction from "old importer" and "new importer" and we could get rid of a Wiki page to maintain that explain things, countless bug reports about dxf imported wrongly and so on.

Why not?

Regards

Carlo D.