DXFNext

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: DXFNext

Post by adrianinsaval »

Gift wrote: Tue Jun 28, 2022 7:38 pm That is your postulate. Internally there is no Part.Wire. That is a function, which create edges. Inspect the result of the script.
Wire is a shape type and it is differentiable from stand alone edges. https://github.com/FreeCAD/FreeCAD/blob ... e.cpp#L465
sliptonic wrote: Tue Jun 28, 2022 8:00 pm if the issue is speed, why not strive to make ezdxf faster?
python might be the limiting factor
User avatar
sliptonic
Veteran
Posts: 3457
Joined: Tue Oct 25, 2011 10:46 pm
Location: Columbia, Missouri
Contact:

Re: DXFNext

Post by sliptonic »

adrianinsaval wrote: Tue Jun 28, 2022 9:07 pm python might be the limiting factor
No argument. But it's the limiting factor for everyone. So it still makes sense to address it upstream.
User avatar
Gift
Posts: 769
Joined: Tue Aug 18, 2015 10:08 am
Location: Germany, Sauerland

Re: DXFNext

Post by Gift »

adrianinsaval wrote: Tue Jun 28, 2022 9:07 pm Wire is a shape type and it is differentiable from stand alone edges. https://github.com/FreeCAD/FreeCAD/blob ... e.cpp#L465
...
Good idea. Wire could make it possible. Thanks.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: DXFNext

Post by uwestoehr »

Many thanks for your great work! The new DXF was merged today.
Can you please add something to the release notes?: https://wiki.freecadweb.org/Release_notes_1.0

Also please open a new thread in the General help forum with request to test the next weekly build with real-life DXFs. Usually ;) there will be here and there some issues that will be uncovered by intensive tests.
User avatar
NewJoker
Veteran
Posts: 3017
Joined: Sun Oct 11, 2020 7:49 pm

Re: DXFNext

Post by NewJoker »

@Gift What is the status of this functionality ? It was merged with this PR: https://github.com/FreeCAD/FreeCAD/pull/7101
but is it fully merged or does it require some additional PRs ? Can it be added to the release notes already ?
User avatar
Gift
Posts: 769
Joined: Tue Aug 18, 2015 10:08 am
Location: Germany, Sauerland

Re: DXFNext

Post by Gift »

NewJoker wrote: Thu Sep 22, 2022 1:46 pm @Gift What is the status of this functionality ? It was merged with this PR: https://github.com/FreeCAD/FreeCAD/pull/7101
but is it fully merged or does it require some additional PRs ? Can it be added to the release notes already ?
Up to this point, it is a pure code cleaning. Duplicate files were removed and restructured. A vision should be formulated for further steps. The interest for the support of a ready python library was/is quite high.
But this would only comply a part of the task. A solution would be to make a part of the work even more abstract. A kind of general interface. However. More PRs are needed for this.
User avatar
onekk
Veteran
Posts: 6144
Joined: Sat Jan 17, 2015 7:48 am
Contact:

Re: DXFNext

Post by onekk »

Hello, IMHO @Gift solution could be the stock way of managing DXF, at least to eliminate the gap between "python importer" and "C++ importer".

And the library solution could be left for "complicated cases" and as an optional solution.

If obviously @Gift is taking care of the code.

I see the advantage of the external library, but even an out of the box importer and exporter for DXF file, that could manage "not too exotic" cases and with some speed gain it is not a bad thing.

But this from a user point of view.

Postponing solutions or like in this case some improvement to a uncertain future were "someone" will take care of rewriting things is not a good path for evolution.

If @Gift is able and want to take care of this thing I see no problem, if someone will integrate a dxf import library in FreeCAD, perfect we will have more choice.

But actually if there will be no distinction from "old importer" and "new importer" and we could get rid of a Wiki page to maintain that explain things, countless bug reports about dxf imported wrongly and so on.

Why not?

Regards

Carlo D.
GitHub page: https://github.com/onekk/freecad-doc.
- In deep articles on FreeCAD.
- Learning how to model with scripting.
- Various other stuffs.

Blog: https://okkmkblog.wordpress.com/
Post Reply