One common saying is that "Perfect is the enemy of good" applies here very well. Realthunder has implementation that is superior compared to current implementation and should therefore be merged by merit base as fast as possible to master. I am little worried seeing a lot of "non-toponaming" development going to master as that may now add extra effort to port the toponaming to latest codebase. What I have understood from Realthunders messages he is actually already doing that but as the master is moving target it would be good to get at least some version of core-code already in if possible to do it in a way that it does not break anything.C_h_o_p_i_n wrote: ↑Wed Jul 20, 2022 2:06 pm Please jump over your shadows - It just need to be integrated.
Just my 2 cents, regards, Stefan
And usually the best way to learn the "new code" happens automatically when you debug it, so I would not put too much effort for the requirements that everybody must understand that code before the merge if it's just tested to work.
Once one implementation is in, it's also easier for somebody to think some sensible interfaces if there raises a need for having for example alternative algorithms for solving tpn problems in future. So just hope that realthunders tpn implementation just goes in soon.