Page 6 of 18

Re: Supporting Qt 6 - What's needed?

Posted: Sat Jun 25, 2022 8:23 pm
by Kunda1
Porting from PySide2 to PySide6: https://doc.qt.io/qtforpython/porting_from2.html

Re: Supporting Qt 6 - What's needed?

Posted: Sat Jun 25, 2022 10:15 pm
by chennes
For those of you who have been working on this, is there any mergeable code yet? It doesn’t have to be a complete working Qt6 FreeCAD, but if some modules are ready to go I think we should start putting it in, otherwise we are going to have a monster PR. Qt6 is now included in many mainstream distros, and while we expect our next release to have a min Qt of 5.12, it would certainly be nice to support 6.2+ as well.

Re: Supporting Qt 6 - What's needed?

Posted: Sun Jun 26, 2022 11:28 am
by Kunda1
Totally agree

Re: Supporting Qt 6 - What's needed?

Posted: Mon Jul 04, 2022 5:04 pm
by Kunda1
@chennes maybe worth making a separate branch for qt6/pyside6 migration ?

Edit: one reason would be that we can use the Clazy based porting tool to help with the migration (see issue #7134)

Re: Supporting Qt 6 - What's needed?

Posted: Wed Jul 06, 2022 3:49 pm
by chennes
I'm very hesitant to make a separate branch for this work, since of course the final product needs to be a build system that can compile either Qt5 or Qt6 depending on user preference. I'd prefer to just work on the master branch as usual.

Re: Supporting Qt 6 - What's needed?

Posted: Wed Jul 06, 2022 3:53 pm
by Kunda1
Ok, so if not a separate branch, then do we have folks interested in participating or who have already started working on this?

Re: Supporting Qt 6 - What's needed?

Posted: Wed Jul 06, 2022 8:09 pm
by doia
Please do NOT work directly on the master branch! This will give a lot of headaches as the work on migrating to/ adding QT6 may involve a lot of commits. These commits will then be mixed with a all the other commits, which makes it hard to follow. And is bad practise anyways.
Instead use a separate branch which is rebased on master and merged if finished.

Re: Supporting Qt 6 - What's needed?

Posted: Thu Jul 07, 2022 3:52 pm
by Kunda1
FWIW, I agree with @doia

Re: Supporting Qt 6 - What's needed?

Posted: Thu Jul 07, 2022 5:19 pm
by chennes
We certainly expect the actual developers of the PRs to operate on non-master branches: but the PR(s) themselves will be merged into master when they are ready. I don't see a point in actually forming a separate branch in the main depot for FreeCAD. What advantage do you see?

Re: Supporting Qt 6 - What's needed?

Posted: Thu Jul 07, 2022 6:07 pm
by obelisk79
chennes wrote: Thu Jul 07, 2022 5:19 pm What advantage do you see?
Just a layman's thoughts. But wouldn't that centralize work between multiple contributors in the process of migrating to QT6 potentially preventing duplication of effort? Or is this something we're expecting only one or maybe two people to tackle? Once the work is done and merged with master, the branch can be deleted/archived to avoid excess clutter in the github branch listing.