Back port commits to 0.19 branch

[Syres]

Also please add https://github.com/FreeCAD/FreeCAD/pull/4644 to the backports, there's been a report of missing icon on toolbar of Part Wb.

[uwestoehr]

Also please add https://github.com/FreeCAD/FreeCAD/pull/4644 to the backports, there's been a report of missing icon on toolbar of Part Wb.

Thanks, it is in the list now.

[chennes]

https://github.com/FreeCAD/FreeCAD/pull/4644

Yes, I've added that one too, thanks.

[chennes]

I have backported the PRs that were on my list to handle to the 0.19 branch, all of them applied cleanly. If anyone has free time, it would be good for other people to check out the head of that branch (not the release tag) and try to compile and run 0.19.x. Thanks!

[bernd]

should we backport CI commits and try to run CI on this branch ?

[chennes]

I think that's a good idea, especially because CI changes can't break the build, so are basically safe by definition, right?

[uwestoehr]

I have backported the PRs that were on my list to handle to the 0.19 branch, all of them applied cleanly.

Many thanks!
Could you please update the list accordingly? As you wrote, some backport requests should be reviewed by others. Can you add this info behind the item in the list?

[chennes]

Can you add this info behind the item in the list?

What info do you need? I indicated the ones that are staged, but we haven't tagged the next release yet.

[uwestoehr]

What info do you need? I indicated the ones that are staged, but we haven't tagged the next release yet.

Add "added for v0.19.3" behind the merged ones and strike them trough.
For the unmerged ones you have a capable developer in mind you could e.g. write "to be reviewed by e.g. xxx". where xxx is the name of a developer you have in mind. Just a proposal.

Although there is no tagged release, we know that the next bugfix release will be 0.19.3, so everyone looking at the list knows, that these backports will be part of the upcoming release. And also nice for users is to see that there will be a further bugfix release at all

[bernd]

I think that's a good idea, especially because CI changes can't break the build, so are basically safe by definition, right?

somehow I can not push to FreeCAD-0-19 branch ... pushing to master still works for me. Is there anything special with this branch?

cheers bernd