Back port commits to 0.19 branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Post Reply
User avatar
uwestoehr
Veteran
Posts: 4077
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany

Back port commits to 0.19 branch

Post by uwestoehr »

This thread is to collect commits and PRs to be backported to the stable FC 0-19 branch.

Memory leak or dataloss fixes:
* https://github.com/FreeCAD/FreeCAD/commit/4e4068e4 (added for to v0.19.2)
* https://github.com/FreeCAD/FreeCAD/commit/4e4068e4 (added for v0.19.2)
* https://github.com/FreeCAD/FreeCAD/commit/6f145570 (can be ignored for v0.19)
* https://github.com/FreeCAD/FreeCAD/commit/7f01c558 (can be ignored for v0.19)
* https://github.com/FreeCAD/FreeCAD/commit/733cbce2 (can be ignored for v0.19)
* https://github.com/FreeCAD/FreeCAD/pull/4792 (added for v0.19.3)

Addon manager fixes:
* https://github.com/FreeCAD/FreeCAD/pull/5041 (added for v0.19.3)

Arch fixes:
* https://github.com/FreeCAD/FreeCAD/pull/4745 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4748 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/5388 (added for v0.19.4)
* https://github.com/FreeCAD/FreeCAD/pull/5465 (added for v0.19.4)

Core (App and Gui) fixes:
* https://github.com/FreeCAD/FreeCAD/pull/4800 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4996 (adds new features, thus no backport)
* https://github.com/FreeCAD/FreeCAD/pull/5045 (hotfix for PR 4996, thus no backport)
* https://github.com/FreeCAD/FreeCAD/pull/5103 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/5215 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/5299 (added for v0.19.4)
* https://github.com/FreeCAD/FreeCAD/pull/5492 (added for v0.19.4)

Draft fixes:
* https://github.com/FreeCAD/FreeCAD/pull/4743 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/5233 (added for v0.19.4)
* git commit 8585149a (added for v0.19.4)
* git commit 1742d7ff (added for v0.19.4)
* https://github.com/FreeCAD/FreeCAD/pull/5280 (added for v0.19.4)
* https://github.com/FreeCAD/FreeCAD/pull/5297 (added for v0.19.4)
* https://github.com/FreeCAD/FreeCAD/pull/5317 (added for v0.19.4)
* git commit 325c5ec8 (added for v0.19.4)
* https://github.com/FreeCAD/FreeCAD/pull/5449 (added for v0.19.4)
* https://github.com/FreeCAD/FreeCAD/pull/5476 (added for v0.19.4)
* https://github.com/FreeCAD/FreeCAD/pull/6444 (added for v0.19.4)

Import/Export fixes:
* https://github.com/FreeCAD/FreeCAD/pull/5098 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/6470 (added for v0.19.4)

Part fixes:
* https://github.com/FreeCAD/FreeCAD/pull/4644 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/5138 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/commit/782f9c93 (added for v0.19.4)
* https://github.com/FreeCAD/FreeCAD/pull/5348 (added for v0.19.4)

PartDesign fixes:
* https://github.com/FreeCAD/FreeCAD/commit/b33324a5 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/5149 (added for v0.19.3)
* git commit 6167e9f7 (added for v0.19.4)
* https://github.com/FreeCAD/FreeCAD/pull/5236 (added for v0.19.4)

Path fixes:
* https://github.com/FreeCAD/FreeCAD/pull/4613 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4615 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4622 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4639 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4673 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4680 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4765 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4796 (added for v0.19.3
* https://github.com/FreeCAD/FreeCAD/pull/4797 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4815 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4819 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4857 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4864 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4906 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4909 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4919 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4936 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4939 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/commit/db16029c (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4953 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4973 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4986 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/5008 (to be revised by @sliptonic)
* https://github.com/FreeCAD/FreeCAD/pull/5076 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/5306 (added for v0.19.4)
* https://github.com/FreeCAD/FreeCAD/pull/5343 (added for v0.19.4)

Spreadsheet fixes:
* https://github.com/FreeCAD/FreeCAD/pull/5030 (added for 0.19.3)

Sketcher fixes:
* https://github.com/FreeCAD/FreeCAD/pull/4744 (added for 0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4832 (added for 0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/5190 (added for 0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/5197 (added for 0.19.4)

TechDraw fixes:
* https://github.com/FreeCAD/FreeCAD/pull/4895 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/5013 (added for 0.19.4)
* https://github.com/FreeCAD/FreeCAD/pull/5016 (added for 0.19.4)
* https://github.com/FreeCAD/FreeCAD/pull/5283 (added for 0.19.4)
* https://github.com/FreeCAD/FreeCAD/pull/5477 (added for 0.19.4)

Web fixes:
* git commit 18b3c59d (added for v0.19.4)

Compilation issues:
* git commit 6ad156b6 (added for v0.19.4)
* git commit 833868bd (added for v0.19.4)
* git commit 6d2aa6ac (added for v0.19.4)
* git commit 5fba9cec (added for v0.19.4)

Stylesheet issues:
* https://github.com/FreeCAD/FreeCAD/pull/4719 (added for v0.19.2)
* https://github.com/FreeCAD/FreeCAD/pull/4739 (added for v0.19.2)
* https://github.com/FreeCAD/FreeCAD/pull/4513 (shouldn't be added to v0.19)
* https://github.com/FreeCAD/FreeCAD/pull/4694 (adds new feature, thus no backport)

Miscellaneous:
* https://github.com/FreeCAD/FreeCAD/pull/4767 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4771 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4782 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4912 (added for v0.19.3)
* https://github.com/FreeCAD/FreeCAD/pull/4691 (added for v0.19.2)
* https://github.com/FreeCAD/FreeCAD/pull/4648 (added for v0.19.2)
* https://github.com/FreeCAD/FreeCAD/pull/4661 (added for v0.19.2)
* https://github.com/FreeCAD/FreeCAD/pull/4552 (Like PR4513 this shouldn't be added to v0.19 because of packaging problems)
* git commit 76c611ae (added for v0.19.4)

The forum maintainers (everybody who can modify this post) can strike-through either released or rejected backports.
Last edited by uwestoehr on Mon Sep 20, 2021 6:03 pm, edited 18 times in total.
chrisb
Veteran
Posts: 43066
Joined: Tue Mar 17, 2015 9:14 am

Re: Back port commits to 0.19 branch

Post by chrisb »

uwestoehr wrote: Sun Apr 11, 2021 12:30 am Can anybody please pin this thread?
Done.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Syres
Veteran
Posts: 1548
Joined: Thu Aug 09, 2018 11:14 am

Re: Back port commits to 0.19 branch

Post by Syres »

Please add git commit 8ec9bfa to the list
chrisb
Veteran
Posts: 43066
Joined: Tue Mar 17, 2015 9:14 am

Re: Back port commits to 0.19 branch

Post by chrisb »

Is there some strategy what should be backported? People who want to have everything can always use 0.20. There are two things that should always be backported: security fixes, and everything which could cause data loss or damage. Severe handling issues could be added, but nice to have things should go into 0.20.
This would have been different, if we were still in a 0.19.2 development cycle without having started 0.20.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
turn211
Posts: 162
Joined: Mon Feb 01, 2021 11:37 pm

Re: Back port commits to 0.19 branch

Post by turn211 »

chrisb wrote: Sun Apr 11, 2021 5:40 pm Is there some strategy what should be backported? People who want to have everything can always use 0.20. There are two things that should always be backported: security fixes, and everything which could cause data loss or damage. Severe handling issues could be added, but nice to have things should go into 0.20.
This would have been different, if we were still in a 0.19.2 development cycle without having started 0.20.
So far all I see are usability and bug fixes that prevent FreeCAD from being useable to any degree with stylesheets. All the stylesheet fixes from the qt 5.15.1 bug, black icons on black background, disappearing tabs, unreadable url links. These are all fixed and the community is waiting. I and others have put a lot of effort in squashing these bugs. Let's get them out there where people can see them, not buried in a development release. Ps The 0.20 releases are still broken on Windows due to the QT 5.15.1 bugs. Got to start building on QT 5.15.2
User avatar
Kunda1
Veteran
Posts: 12561
Joined: Thu Jan 05, 2017 9:03 pm

Re: Back port commits to 0.19 branch

Post by Kunda1 »

This is why we really need to rethink our release strategies and why I started the discussion over at https://forum.freecadweb.org/viewtopic.php?f=10&t=57440

The 0.18.x backports were really confusing especially everything after v0.18.4 (of course it also had to do with the awkward challenge of transitioning to py3 and qt5 and that it was a 2 year release) but we shouldn't repeat that behavior.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
uwestoehr
Veteran
Posts: 4077
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany

Re: Back port commits to 0.19 branch

Post by uwestoehr »

I think we need a stable release maintainer. Someone who decides what is backported and when there are either enough fixes or a severe bugfix, decides for a new release.

For now I'll try to keep the initial post up to date to keep the overview.

From my perspective we already agree that a 0.19.2 release should be made to make FC 0.19 usable with stylesheets. So all fixes related to styles should go in. They don't change FC's functionality and I know that a lot of users love customized program interfaces.
adrianinsaval
Veteran
Posts: 2642
Joined: Thu Apr 05, 2018 5:15 pm

Re: Back port commits to 0.19 branch

Post by adrianinsaval »

I think the memory leak bug is kinda important, the other one I proposed that fixes the start workbench test is trivial so it can't really hurt.
Post Reply