Remind me what is your github username?
Helping to review pull requests
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: Helping to review pull requests
Re: Helping to review pull requests
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
- ebrahim raeyat
- Posts: 619
- Joined: Sun Sep 09, 2018 7:00 pm
- Location: Iran
- Contact:
Re: Helping to review pull requests
Thanks Kunda1
Re: Helping to review pull requests
Thanks! You are added Ebrahim!
- ebrahim raeyat
- Posts: 619
- Joined: Sun Sep 09, 2018 7:00 pm
- Location: Iran
- Contact:
Re: Helping to review pull requests
Thanks, it is very interesting, I am a member of FreeCAD
-
- Posts: 529
- Joined: Fri Sep 18, 2020 5:40 pm
Re: Helping to review pull requests
I volunteer to be a reviewer my GitHub Id is @davidosterberg
Re: Helping to review pull requests
Added!davidosterberg wrote: ↑Wed Dec 16, 2020 10:04 pm I volunteer to be a reviewer my GitHub Id is @davidosterberg
- DrInfiniteExplorer
- Posts: 39
- Joined: Wed Dec 30, 2020 2:16 am
Re: Helping to review pull requests
I'd like to review some as well. Github id is DrInfiniteExplorer
Edit: But I haven't been able to find any guidelines for code style, formatting, pep8, typing, or review process in general.
Does any of that exist for FreeCAD?
Edit: But I haven't been able to find any guidelines for code style, formatting, pep8, typing, or review process in general.
Does any of that exist for FreeCAD?
Re: Helping to review pull requests
Added!
Note for future people interested, this is apparently not needed anymore, anyone can start a review on the FreeCAD pull requests. And your contributions will be there the same way, visible to all
About code style guides, no, we haven't anything really official, although many people have tried starting things like that... At the moment I'd say we look more to have things that are more or less well constructed and don't break anything. FreeCAD also being a very hybrid code with different languages and libraries makes it harder to get everyone to follow one determined code styling.
Note for future people interested, this is apparently not needed anymore, anyone can start a review on the FreeCAD pull requests. And your contributions will be there the same way, visible to all
About code style guides, no, we haven't anything really official, although many people have tried starting things like that... At the moment I'd say we look more to have things that are more or less well constructed and don't break anything. FreeCAD also being a very hybrid code with different languages and libraries makes it harder to get everyone to follow one determined code styling.
Re: Helping to review pull requests
As I said in another thread, while I think it's good to have a bunch of reviewers, this is more important to have a review process especially stating clearly what are the expectations from the trusted mergers so a PR is considered 'mergeable'. If it appears that @wmayer only trusts himself (which would be an acceptable statement) to review and merge a PR in App or Part or PartDesign, better know it so nobody wastes time.
PS : also define how reviewers shall flag PR when it is reviewed OK.