Helping to review pull requests

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
yorik
Founder
Posts: 13640
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: Helping to review pull requests

Post by yorik »

ebrahim raeyat wrote: Tue Dec 15, 2020 9:25 am Please add me, I hope i can help the community.
Remind me what is your github username?
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Helping to review pull requests

Post by Kunda1 »

yorik wrote: Tue Dec 15, 2020 11:46 am
ebrahim raeyat wrote: Tue Dec 15, 2020 9:25 am Please add me, I hope i can help the community.
Remind me what is your github username?
@ebrahimraeyat
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
ebrahim raeyat
Posts: 619
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: Helping to review pull requests

Post by ebrahim raeyat »

Kunda1 wrote: Tue Dec 15, 2020 12:12 pm
yorik wrote: Tue Dec 15, 2020 11:46 am
ebrahim raeyat wrote: Tue Dec 15, 2020 9:25 am Please add me, I hope i can help the community.
Remind me what is your github username?
@ebrahimraeyat
Thanks Kunda1 :)
User avatar
yorik
Founder
Posts: 13640
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: Helping to review pull requests

Post by yorik »

Thanks! You are added Ebrahim!
User avatar
ebrahim raeyat
Posts: 619
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: Helping to review pull requests

Post by ebrahim raeyat »

yorik wrote: Wed Dec 16, 2020 11:33 am Thanks! You are added Ebrahim!
Thanks, it is very interesting, I am a member of FreeCAD :o
davidosterberg
Posts: 529
Joined: Fri Sep 18, 2020 5:40 pm

Re: Helping to review pull requests

Post by davidosterberg »

I volunteer to be a reviewer my GitHub Id is @davidosterberg
User avatar
yorik
Founder
Posts: 13640
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: Helping to review pull requests

Post by yorik »

davidosterberg wrote: Wed Dec 16, 2020 10:04 pm I volunteer to be a reviewer my GitHub Id is @davidosterberg
Added!
User avatar
DrInfiniteExplorer
Posts: 39
Joined: Wed Dec 30, 2020 2:16 am

Re: Helping to review pull requests

Post by DrInfiniteExplorer »

I'd like to review some as well. Github id is DrInfiniteExplorer

Edit: But I haven't been able to find any guidelines for code style, formatting, pep8, typing, or review process in general.
Does any of that exist for FreeCAD?
User avatar
yorik
Founder
Posts: 13640
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: Helping to review pull requests

Post by yorik »

Added!

Note for future people interested, this is apparently not needed anymore, anyone can start a review on the FreeCAD pull requests. And your contributions will be there the same way, visible to all ;)

About code style guides, no, we haven't anything really official, although many people have tried starting things like that... At the moment I'd say we look more to have things that are more or less well constructed and don't break anything. FreeCAD also being a very hybrid code with different languages and libraries makes it harder to get everyone to follow one determined code styling.
openBrain
Veteran
Posts: 9034
Joined: Fri Nov 09, 2018 5:38 pm
Contact:

Re: Helping to review pull requests

Post by openBrain »

yorik wrote: Mon Jan 04, 2021 1:10 pm Added!

Note for future people interested, this is apparently not needed anymore, anyone can start a review on the FreeCAD pull requests. And your contributions will be there the same way, visible to all ;)
As I said in another thread, while I think it's good to have a bunch of reviewers, this is more important to have a review process especially stating clearly what are the expectations from the trusted mergers so a PR is considered 'mergeable'. If it appears that @wmayer only trusts himself (which would be an acceptable statement) to review and merge a PR in App or Part or PartDesign, better know it so nobody wastes time. ;)
PS : also define how reviewers shall flag PR when it is reviewed OK.
Post Reply