Search found 60 matches

by tpavlicek
Sun Mar 17, 2024 8:30 pm
Forum: TechDraw
Topic: Filling Template Fields
Replies: 6
Views: 594

Re: Filling Template Fields

Here goes my reply to to @ab0v3g4me GitHub comments : The autofill action is one-time trigger when a new page is added. After that, everything can be manually changed and once saved, the exact texts are restored when loaded. I have no objection to automatically fillling the mass field, but the big q...
by tpavlicek
Mon Nov 22, 2021 3:04 pm
Forum: Help on using FreeCAD
Topic: Arbitrary tree ordering messes up duplication of PD bodies
Replies: 48
Views: 9717

Re: Arbitrary tree ordering messes up duplication of PD bodies

drmacro wrote: Mon Nov 22, 2021 2:49 pm And now we have duelling PR's...
Well, I hope Chris would decide for the fix, so at least he can save his time for something better ;-)


Tomas
by tpavlicek
Mon Nov 22, 2021 1:04 pm
Forum: Help on using FreeCAD
Topic: Arbitrary tree ordering messes up duplication of PD bodies
Replies: 48
Views: 9717

Re: Arbitrary tree ordering messes up duplication of PD bodies

Hello,

I believe I have a fix for the problems described above, the changes are in Pull Request #5195.

If anyone compiles FreeCAD for themselves, please test the branch, if there are any outstanding issues.

Thank you for your patience and understanding,


Tomas
by tpavlicek
Fri Nov 19, 2021 6:43 pm
Forum: Help on using FreeCAD
Topic: Arbitrary tree ordering messes up duplication of PD bodies
Replies: 48
Views: 9717

Re: Arbitrary tree ordering messes up duplication of PD bodies

Hi to all, it seems there may be some bugs in the implementation. Just to be on the same page, I recap the functionality: It should allow reorder any items on the top (document) level or inside any parent group not forbidding order changes Any reordering within a Part Design body is forbidden - ther...
by tpavlicek
Sat Oct 02, 2021 9:40 pm
Forum: TechDraw
Topic: Balloon improvements
Replies: 9
Views: 5241

Balloon improvements

Hello, I have created Pull Request #5082 with several improvements in "Balloon" handling. It is touching following areas: 1. New "bubble" shape Line style, underlining the ballon text Balloon1.png This style is neccessary when the drawings must be made according to the ISO norms....
by tpavlicek
Sun Aug 22, 2021 9:24 am
Forum: Part Design module development
Topic: [Sketcher] Possible bug in new line split code
Replies: 4
Views: 3727

Re: [Sketcher] Possible bug in new line split code

Hello, the intention here is to stop any further processing if adding a new edge failed. I agree, the whole construction do { ... if (...) continue; ... } while (false); is rather unorthodox, but goto could be considered even worse ;-) Of course, I could have replaced this by try/catch, but I am rat...
by tpavlicek
Mon Aug 09, 2021 6:27 pm
Forum: TechDraw
Topic: Edit annotations on double-click
Replies: 5
Views: 2591

Re: Edit annotations on double-click

Hello Uwe,

thanks for Your review and valuable fix suggestion. I have added new commits with changes, if You will find some time to test them, I would be glad.

Kind regards,

Tomas
by tpavlicek
Fri Jul 02, 2021 9:08 am
Forum: TechDraw
Topic: [Fixed] TechDraw source code RichTextAnnotation artifacts
Replies: 6
Views: 3179

Re: TechDraw source code RichTextAnnotation artifacts

Hi,

I have created Pull Request #4904 for the removal.

Kind regards,


Tomas
by tpavlicek
Thu Jul 01, 2021 8:48 pm
Forum: TechDraw
Topic: [Fixed] TechDraw source code RichTextAnnotation artifacts
Replies: 6
Views: 3179

Re: TechDraw source code RichTextAnnotation artifacts

From my point of view it is pretty much safe to remove the code from Gui/CommandDecorate.cpp. The additional code lines are rather an artifact from copied and pasted "Add Leader Line" code.

Kind regards,


Tomas
by tpavlicek
Thu Jul 01, 2021 8:37 pm
Forum: TechDraw
Topic: Edit annotations on double-click
Replies: 5
Views: 2591

Re: Edit annotations on double-click

Hello, So instead of renaming it you'd like to jump to editing the text itself? Probably you mean double-clicking on the tree view item? This is unchanged for both types. In the pull request the editor is brought up only when double-clicking on the annotation text in the page. At this moment double-...